feat: support schema registry in risedev #17001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
commented
May 29, 2024
Comment on lines
-1435
to
-1436
| # Listen address | ||
| listen-address: ${address} |
Signed-off-by: xxchan <[email protected]>
xxchan
commented
May 29, 2024
| @@ -1,3 +1,6 @@ | |||
| control substitution on | |||
There was a problem hiding this comment.
Only try RISEDEV_SCHEMA_REGISTRY_URL in this test. Not bother to modify others.
Signed-off-by: xxchan <[email protected]>
BugenZhao
approved these changes
May 30, 2024
Comment on lines
+287
to
+288
| let mut task = | ||
| risedev::TcpReadyCheckTask::new(c.address.clone(), c.port, c.user_managed)?; |
There was a problem hiding this comment.
Have you checked whether this is accurate?
There was a problem hiding this comment.
maybe perform a GET request and check the code equals to 200. Here's an example
curl -X GET http://localhost:8081/subjects
| @@ -1,3 +1,6 @@ | |||
| control substitution on | |||
|
|
|||
| # FIXME: does this really work?? | |||
| } | ||
|
|
||
| fn data_path(&self) -> Option<String> { | ||
| None |
There was a problem hiding this comment.
Shall we support persisting data?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xxchan [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related: #16903, prepare for #16931
Besides, don't use redpanda schema registry in ci to reduce confusion.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.