Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): deprecate zookeeper & use kraft mode for kafka service #16600

Merged
merged 4 commits into from
May 7, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

...so that one service is reduced when launching Kafka with RiseDev.

This is a reopen of #16541, which was accidentally merged into #16584.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao requested review from stdrc, xxchan and kwannoel May 7, 2024 06:02
Copy link
Member Author

BugenZhao commented May 7, 2024

@BugenZhao BugenZhao force-pushed the bz/backward-compat-ci-kafka-k8s branch from 48110e1 to da656c1 Compare May 7, 2024 07:52
@BugenZhao BugenZhao force-pushed the bz/deprecate-zookeeper-kafka-risedev-retry branch from 88cfb55 to 18c35d9 Compare May 7, 2024 07:52
Base automatically changed from bz/backward-compat-ci-kafka-k8s to main May 7, 2024 09:24
@BugenZhao BugenZhao force-pushed the bz/deprecate-zookeeper-kafka-risedev-retry branch from 18c35d9 to b9048ed Compare May 7, 2024 15:43
@BugenZhao BugenZhao enabled auto-merge May 7, 2024 15:43
@BugenZhao BugenZhao added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 39491e6 May 7, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/deprecate-zookeeper-kafka-risedev-retry branch May 7, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants