Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): use ci-provisioned message-queue service in backwards-compat tests #16584

Merged
merged 4 commits into from
May 7, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Check #16541 (comment) for the background for this change.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao added the ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. label May 6, 2024
@BugenZhao BugenZhao requested review from xxchan and kwannoel May 6, 2024 07:16
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice solution

@BugenZhao BugenZhao changed the title refactor(test): use ci-provisioned kafka service in backwards-compat tests refactor(test): use ci-provisioned message-queue service in backwards-compat tests May 6, 2024
@BugenZhao BugenZhao enabled auto-merge May 6, 2024 08:56
@BugenZhao BugenZhao added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@BugenZhao BugenZhao force-pushed the bz/backward-compat-ci-kafka-k8s branch from c12bf3c to 48110e1 Compare May 7, 2024 05:59
@BugenZhao BugenZhao enabled auto-merge May 7, 2024 06:00
@BugenZhao BugenZhao added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@BugenZhao BugenZhao added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@BugenZhao BugenZhao force-pushed the bz/backward-compat-ci-kafka-k8s branch from 48110e1 to da656c1 Compare May 7, 2024 07:52
Copy link
Member Author

@BugenZhao BugenZhao enabled auto-merge May 7, 2024 08:53
@BugenZhao BugenZhao added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit f7d9ff7 May 7, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/backward-compat-ci-kafka-k8s branch May 7, 2024 09:24
github-actions bot pushed a commit that referenced this pull request May 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 16, 2024
…-compat tests (#16584) (#16786)

Signed-off-by: Bugen Zhao <[email protected]>
Co-authored-by: Bugen Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants