Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sink): DRY SinkFormatterImpl::new #16575

Merged
merged 7 commits into from
May 6, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented May 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Split the monolithic SinkFormatterImpl::new into extensible EncoderBuild & FormatterBuild pieces. The dispatcher logic in SinkFormatterImpl::new is now simply matching from (format, encode) into a variant of the SinkFormatterImpl enum.

This is NOT a purely equivalent refactor. By reducing the repetition, it also:

  • supported schemas.enable option for format plain encode json, which was only available for format upsert encode json #12113.
  • fixed partition skew problem when encode template is used with format plain without key. The encode json case was fixed in #12810.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu marked this pull request as ready for review May 6, 2024 07:08
@xiangjinwu xiangjinwu requested review from tabVersion and xxhZs May 6, 2024 07:19
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor. It helps a lot with adding new sink format impl combinations 🫡

@xiangjinwu xiangjinwu added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 16dbae3 May 6, 2024
29 of 30 checks passed
@xiangjinwu xiangjinwu deleted the refactor-sink-formatter-impl-new branch May 6, 2024 09:31
xxhZs pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants