Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use avg instead of sum for join actor metrics #15374

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Feb 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #14448 (comment)

summing over all the actors that belong to the same fragment makes little sense, and it even sums three different sides, i.e. left, right and barrier.

avg should make more sense than sum.

Does quantile, i.e. 50th, 90th, 99th, make even more sense than avg?

Previously
SCR-20240229-vwt

Now
SCR-20240229-vwq

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz requested a review from fuyufjh February 29, 2024 14:59
@github-actions github-actions bot added the type/fix Bug fix label Feb 29, 2024
@lmatz lmatz added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 533af26 Mar 1, 2024
11 of 12 checks passed
@lmatz lmatz deleted the lz/join_metrics branch March 1, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking: improve scaling up performance
2 participants