Skip to content

Commit

Permalink
fix: use avg instead of sum for join actor metrics (#15374)
Browse files Browse the repository at this point in the history
  • Loading branch information
lmatz authored Mar 1, 2024
1 parent d00d286 commit 533af26
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docker/dashboards/risingwave-dev-dashboard.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docker/dashboards/risingwave-user-dashboard.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions grafana/risingwave-dev-dashboard.dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ def section_streaming_actors(outer_panels):
"",
[
panels.target(
f"sum(rate({metric('stream_join_actor_input_waiting_duration_ns')}[$__rate_interval]) / 1000000000) by (fragment_id)",
f"avg(rate({metric('stream_join_actor_input_waiting_duration_ns')}[$__rate_interval]) / 1000000000) by (fragment_id)",
"fragment {{fragment_id}}",
),
panels.target_hidden(
Expand All @@ -1264,7 +1264,7 @@ def section_streaming_actors(outer_panels):
"",
[
panels.target(
f"sum(rate({metric('stream_join_match_duration_ns')}[$__rate_interval]) / 1000000000) by (fragment_id)",
f"avg(rate({metric('stream_join_match_duration_ns')}[$__rate_interval]) / 1000000000) by (fragment_id,side)",
"fragment {{fragment_id}} {{side}}",
),
panels.target_hidden(
Expand Down
2 changes: 1 addition & 1 deletion grafana/risingwave-dev-dashboard.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion grafana/risingwave-user-dashboard.json

Large diffs are not rendered by default.

0 comments on commit 533af26

Please sign in to comment.