-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): add embedded-python-udf
feature and fix dockerfile
#15328
Conversation
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
embedded-python-udf
feature and fix dockerfileembedded-python-udf
feature and fix dockerfile
Signed-off-by: Runji Wang <[email protected]>
d0b6477
to
51ce3d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
My concern is that off-by-default features could be fragile to maintain as most of the developers won't realize its existence. 😕 Fortunately, risingwave/ci/scripts/check.sh Line 24 in 06e28e8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release.sh is not updated, so binary release won't contain it. 😄
Hmmm, but if we enable it for binary release, users without python3.12 will not be able to start RisingWave. 🤔 |
Indeed... We should make it static linked. |
Strong +1 for this. 🥺 Also I think it's okay to make it a default feature.
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR makes
embedded-python-udf
an optional feature. This feature is not enabled by default so that developers are not required to have Python 3.12 installed. To enable it, you can runENABLE_PYTHON_UDF=1 ./risedev d
orcargo build --features embedded-python-udf
. This feature is enabled in production build.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.