Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): use #[derive(Fields)] in statement handlers #15130

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Similar to #14947, this PR uses #[derive(Fields)] to help construct rows and schemas in statement handlers.

- Row::new(vec![
-     Some(info.name.clone().into()),
-     Some(info.setting.clone().into()),
-     Some(info.description.clone().into()),
- ])
+ ShowVariableAllRow {
+     name: info.name.clone(),
+     setting: info.setting.clone(),
+     description: info.description.clone(),
+ }

It also introduces an attribute to customize field name style:

#[derive(Fields)]
#[fields(style = "TITLE CASE")] // <--
struct ExplainRow {
    query_plan: String, // field name will be "QUERY PLAN"
}

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/frontend/src/handler/cancel_job.rs Outdated Show resolved Hide resolved
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 force-pushed the wrj/refactor-show branch 2 times, most recently from c9cccb2 to 421deda Compare February 20, 2024 06:22
there is a bug when query in extended mode, the format may be binary, but we always output in text.

Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 20, 2024
You're not authorized to push to this branch. Visit "About protected branches" for more information.
auto-merge was automatically disabled February 22, 2024 06:09

Merge queue setting changed

auto-merge was automatically disabled February 23, 2024 01:45

Merge queue setting changed

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 91d97ac Feb 23, 2024
26 of 27 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/refactor-show branch February 23, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants