Skip to content

Commit

Permalink
revert: varchar -> boolean, varchar -> bigint
Browse files Browse the repository at this point in the history
there is a bug when query in extended mode, the format may be binary, but we always output in text.

Signed-off-by: Runji Wang <[email protected]>
  • Loading branch information
wangrunji0408 committed Feb 20, 2024
1 parent 40aa7b2 commit 2009918
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/frontend/src/handler/cancel_job.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub(super) async fn handle_cancel(
.await?;
let rows = canceled_jobs
.into_iter()
.map(|id| CancelRow { id: id as i32 });
.map(|id| CancelRow { id: id.to_string() });
Ok(PgResponse::builder(StatementType::CANCEL_COMMAND)
.rows(rows)
.into())
Expand All @@ -43,5 +43,5 @@ pub(super) async fn handle_cancel(
#[derive(Fields)]
#[fields(style = "Title Case")]
struct CancelRow {
id: i32,
id: String,
}
4 changes: 2 additions & 2 deletions src/frontend/src/handler/show.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ struct ShowObjectRow {
pub struct ShowColumnRow {
pub name: String,
pub r#type: String,
pub is_hidden: Option<bool>,
pub is_hidden: Option<String>,
pub description: Option<String>,
}

Expand All @@ -135,7 +135,7 @@ impl ShowColumnRow {
ShowColumnRow {
name: c.name,
r#type: type_name,
is_hidden: Some(col.is_hidden),
is_hidden: Some(col.is_hidden.to_string()),
description: c.description,
}
})
Expand Down

0 comments on commit 2009918

Please sign in to comment.