-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(error): move RwError
from common
to frontend
#14953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
4 tasks
9 tasks
xxchan
approved these changes
Feb 2, 2024
4 tasks
stdrc
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fuyufjh
approved these changes
Feb 2, 2024
BugenZhao
force-pushed
the
bz/rw-error-move-into-frontend
branch
from
February 5, 2024 06:40
d62a6fc
to
da33d4a
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/rw-error-move-into-frontend
branch
from
February 5, 2024 07:36
da33d4a
to
07d1685
Compare
Signed-off-by: Bugen Zhao <[email protected]>
This was referenced Feb 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Move
RwError
fromcommon
tofrontend
, as all the usages ofRwError
except for thefrontend
crate have been eliminated after #14950. From now on,RwError
will only act as a top-level error type in the entire codebase.Massive amount of files have been touched, but the only change is to replace
risingwave_common::error
withcrate::error
. One can review this PR commit by commit to get it clear, or just focus on the changes in the following files:common/src/error.rs
frontend/src/error.rs
To make the PR focused on a single stuff, the definition of
ErrorCode
is not touched. Future refactoring has been marked as TODO in the comments.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.