Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(error): move RwError from common to frontend #14953

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Move RwError from common to frontend, as all the usages of RwError except for the frontend crate have been eliminated after #14950. From now on, RwError will only act as a top-level error type in the entire codebase.

Massive amount of files have been touched, but the only change is to replace risingwave_common::error with crate::error. One can review this PR commit by commit to get it clear, or just focus on the changes in the following files:

  • common/src/error.rs
  • frontend/src/error.rs

To make the PR focused on a single stuff, the definition of ErrorCode is not touched. Future refactoring has been marked as TODO in the comments.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao requested a review from a team as a code owner February 2, 2024 07:47
Copy link
Member Author

BugenZhao commented Feb 2, 2024

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao force-pushed the bz/rw-error-move-into-frontend branch from d62a6fc to da33d4a Compare February 5, 2024 06:40
Base automatically changed from bz/connector-refactor-error-2 to main February 5, 2024 07:26
@BugenZhao BugenZhao force-pushed the bz/rw-error-move-into-frontend branch from da33d4a to 07d1685 Compare February 5, 2024 07:36
@BugenZhao BugenZhao enabled auto-merge February 5, 2024 07:43
@BugenZhao BugenZhao added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit eea9a4b Feb 5, 2024
28 of 29 checks passed
@BugenZhao BugenZhao deleted the bz/rw-error-move-into-frontend branch February 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants