Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): fix file format to pass linting #14948

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Feb 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Seems format of dashboard/next.config.js had some problems and npm run lint reported an error, blocking any PR that changed proto files.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Richard Chien <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Feb 2, 2024
@stdrc stdrc enabled auto-merge February 2, 2024 06:19
@BugenZhao
Copy link
Member

The file pattern for triggering CI looks as expected.

paths: [dashboard/**, proto/**]

So this must be because we accidentally disabled the status check on the main branch.

@stdrc stdrc added this pull request to the merge queue Feb 4, 2024
Merged via the queue into main with commit 1eedce1 Feb 4, 2024
15 of 16 checks passed
@stdrc stdrc deleted the rc/fix-dashboard-format branch February 4, 2024 04:53
@BugenZhao BugenZhao mentioned this pull request Feb 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants