Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format dashboard code #14961

Closed
wants to merge 1 commit into from
Closed

chore: format dashboard code #14961

wants to merge 1 commit into from

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Feb 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Actually, I am not sure what happened. just get the error in https://github.com/risingwavelabs/risingwave/actions/runs/7754363835/job/21147562691?pr=14794

npm install

> gen-proto
> ./scripts/generate_proto.sh


> lint
> prettier --check . && next lint

Checking formatting...
[warn] next.config.js
[warn] Code style issues found in the above file. Forgot to run Prettier?
Error: Process completed with exit code 1.

So I run $ prettier --write . on my machine and get the PR.

But this PR fails in the ci. Can any expert take a look?

$ prettier -v
3.2.4

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao
Copy link
Member

We may run npm run format to follow the version of prettier specified in package.json. BTW, the problem should already been resolved in #14948.

@st1page
Copy link
Contributor Author

st1page commented Feb 5, 2024

We may run npm run format to follow the version of prettier specified in package.json. BTW, the problem should already been resolved in #14948.

Thanks!

@st1page st1page closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants