Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support iceberg scan executor #14915

Merged
merged 6 commits into from
Feb 4, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
chenzl25 committed Feb 1, 2024
commit 8f0681bea265ec3f18ea0ee6f92561cebe85726b
3 changes: 2 additions & 1 deletion src/batch/src/executor/iceberg_scan.rs
Original file line number Diff line number Diff line change
@@ -104,7 +104,8 @@ impl Executor for IcebergScanExecutor {
impl IcebergScanExecutor {
#[try_stream(ok = DataChunk, error = BatchError)]
async fn do_execute(self: Box<Self>) {
let table = self.iceberg_config
let table = self
.iceberg_config
.load_table()
.await
.map_err(BatchError::Internal)?;
2 changes: 1 addition & 1 deletion src/connector/src/sink/iceberg/mod.rs
Original file line number Diff line number Diff line change
@@ -392,7 +392,7 @@ impl IcebergConfig {
.into_iter()
.chain(self.table_name.split('.')),
)
.map_err(|e| anyhow!("Unable to parse table name: {e}"))?;
.map_err(|e| anyhow!("Unable to parse table name: {e}"))?;

catalog
.load_table(&table_id)