feat(batch): support iceberg scan executor #14915
Conversation
| let catalog = self.iceberg_config.create_catalog().await?; | ||
|
|
||
| let table_ident = TableIdentifier::new(vec![self.database_name, self.table_name]).unwrap(); | ||
| let table = catalog | ||
| .load_table(&table_ident) | ||
| .await | ||
| .map_err(BatchError::Iceberg)?; | ||
|
|
||
| let table_scan: TableScan = table | ||
| .new_scan_builder() | ||
| .with_snapshot_id( | ||
| self.snapshot_id | ||
| .unwrap_or_else(|| table.current_table_metadata().current_snapshot_id.unwrap()), | ||
| ) | ||
| .with_batch_size(self.batch_size) | ||
| .with_column_names(self.schema.names()) | ||
| .build() | ||
| .map_err(|e| BatchError::Internal(anyhow!(e)))?; | ||
| let file_scan_stream: icelake::io::FileScanStream = | ||
| table_scan.scan(&table).await.map_err(BatchError::Iceberg)?; |
There was a problem hiding this comment.
Usually we do this in planning phase, so that we only need to read metadata for only once, and the scan executor only needs to contains file names.
There was a problem hiding this comment.
wondering if we can do the same as long as setting snapshot_id
There was a problem hiding this comment.
However, icelake currently doesn't provide a way to read Files directly. If we have a better API later, we can avoid such planning in the future.
There was a problem hiding this comment.
wondering if we can do the same as long as setting snapshot_id
Yes, in fact we should set snapshot_id, otherwise different tasks may see different snapshots.
There was a problem hiding this comment.
cc @ZENOTME Could you help to add this api in icelake?
There was a problem hiding this comment.
I would suggest to pending this to wait for icelake's api support, WDYT? cc @chenzl25
There was a problem hiding this comment.
I intend to move fast and present a demo version. Any optimization could be done in parallel as well. 😄
There was a problem hiding this comment.
cc @ZENOTME Could you help to add this api in icelake?
Sorry for replying late. Yes. And I agree to move it now. For the new API, let's track it in icelake as a new feature.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 11fdfcd | ci/scripts/regress-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Does this scan will move to the source executor in the future? |
I think we don't need to merge the iceberg scan executor into the batch source executor. The differences between them are greater than the similarities. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
IcebergScanExecutorwhich could be used to scan an iceberg table and return a DataChunk stream. TheFileSelectoris used to decide which files could be scanned by this executor.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.