Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): bump versions: Node.js to v20, Next.js to 14, typescript to 5.3.3 #14913

Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore(dashboard): bump versions: Node.js to v20, Next.js to 14, typescript to 5.3.3 #14913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/.node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.7.0
v20.11.0
1 change: 1 addition & 0 deletions dashboard/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
* @type {import('next').NextConfig}
*/
const nextConfig = {
output: 'export',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xxchan I remembered that there used to some discussion between us on this.

Copy link
Member Author

@fuyufjh fuyufjh Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for upgrading to next.js v14
https://nextjs.org/docs/pages/building-your-application/upgrading/version-14#v14-summary
https://nextjs.org/docs/app/building-your-application/deploying/static-exports

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember output: 'export' will break build-static, and you suggested a solution phase

#12421 (comment)

Copy link
Member

@xxchan xxchan Feb 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it will break debug build, because it cannot rewrite to mock api conditionally. (I guess so)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you already changed it in #14361

I don't know whether there are any other issues now.

trailingSlash: true,
}

Expand Down
Loading
Loading