-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashboard): bump versions: Node.js to v20, Next.js to 14, typescript to 5.3.3 #14913
Conversation
@@ -19,6 +19,7 @@ | |||
* @type {import('next').NextConfig} | |||
*/ | |||
const nextConfig = { | |||
output: 'export', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @xxchan I remembered that there used to some discussion between us on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required for upgrading to next.js v14
https://nextjs.org/docs/pages/building-your-application/upgrading/version-14#v14-summary
https://nextjs.org/docs/app/building-your-application/deploying/static-exports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember output: 'export'
will break build-static
, and you suggested a solution phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it will break debug build, because it cannot rewrite to mock api conditionally. (I guess so)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you already changed it in #14361
I don't know whether there are any other issues now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title. Hope this can make
Linting and checking validity of types
phase faster.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.