Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): bump versions: Node.js to v20, Next.js to 14, typescript to 5.3.3 #14913

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Hope this can make Linting and checking validity of types phase faster.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@@ -19,6 +19,7 @@
* @type {import('next').NextConfig}
*/
const nextConfig = {
output: 'export',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xxchan I remembered that there used to some discussion between us on this.

Copy link
Member Author

@fuyufjh fuyufjh Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember output: 'export' will break build-static, and you suggested a solution phase

#12421 (comment)

Copy link
Member

@xxchan xxchan Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it will break debug build, because it cannot rewrite to mock api conditionally. (I guess so)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you already changed it in #14361

I don't know whether there are any other issues now.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@fuyufjh fuyufjh enabled auto-merge February 1, 2024 06:56
@fuyufjh fuyufjh added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit d224230 Feb 1, 2024
11 of 13 checks passed
@fuyufjh fuyufjh deleted the eric/bump_nodejs_typescript_version branch February 1, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants