Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): log error field in stream reader retry loop #14792

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix(error): log error field in stream reader retry loop #14792

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb416f
fix(error): log error field in stream reader retry loop
xiangjinwu Jan 25, 2024
acef29d
incl backtrace similar to sink
xiangjinwu Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/stream/src/executor/source/source_executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,10 @@ impl<S: StateStore> SourceExecutor<S> {
) -> StreamExecutorResult<()> {
let core = self.stream_source_core.as_mut().unwrap();
tracing::warn!(
"stream source reader error, actor: {:?}, source: {:?}",
self.actor_ctx.id,
core.source_id,
error = %e.as_report(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the sink side, an error would trigger actor exit and recovery loop, with the error Debugged with backtrace. Shall we follow the same practice here for source and switch from Display to Debug?

risingwave/src/stream/src/task/stream_manager.rs

Lines 694 to 695 in 71898b4

// Intentionally use `?` on the report to also include the backtrace.
tracing::error!(actor_id, error = ?err.as_report(), "actor exit with error");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either LGTM

actor_id = self.actor_ctx.id,
source_id = %core.source_id,
"stream source reader error",
);
GLOBAL_ERROR_METRICS.user_source_reader_error.report([
"SourceReaderError".to_owned(),
Expand Down
Loading