fix(error): log error field in stream reader retry loop #14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
commented
Jan 25, 2024
| "stream source reader error, actor: {:?}, source: {:?}", | ||
| self.actor_ctx.id, | ||
| core.source_id, | ||
| error = %e.as_report(), |
There was a problem hiding this comment.
On the sink side, an error would trigger actor exit and recovery loop, with the error Debugged with backtrace. Shall we follow the same practice here for source and switch from Display to Debug?
risingwave/src/stream/src/task/stream_manager.rs
Lines 694 to 695 in 71898b4
BugenZhao
approved these changes
Jan 25, 2024
| "stream source reader error, actor: {:?}, source: {:?}", | ||
| self.actor_ctx.id, | ||
| core.source_id, | ||
| error = %e.as_report(), |
xiangjinwu
added a commit
that referenced
this pull request
Jan 26, 2024
xiangjinwu
added a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #14755 (comment) (Unauthorized) and #14787 (
unknown yetlz4 unsupported), we can only see the error messagestream source reader errorwithout knowing what the underlying error is.On the contrary, the error message is included as a metrics label. This is an anti-pattern as error message can have high cardinality. However it is not removed in this PR to avoid breaking some people's existing workflow of checking the detailed error on grafana.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.