-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stream): SourceExecutor minor refactor #14706
refactor(stream): SourceExecutor minor refactor #14706
Conversation
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
aa77757
to
3cbc2f2
Compare
/// This function provides the ability to persist the source state | ||
/// and needs to be invoked by the ``SourceReader`` to call it, | ||
/// and will return the error when the dependent ``StateStore`` handles the error. | ||
/// The caller should ensure that the passed parameters are not empty. | ||
pub async fn take_snapshot<SS>(&mut self, states: Vec<SS>) -> StreamExecutorResult<()> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comments are verbose (and a little outdated?).
Function name set_states
might be enough to describe what it does.
Wow, such a complicated topology. 😁 |
Just curious, can Graphite support inheriting from multiple upstream branches? |
3cbc2f2
to
90fc7e5
Compare
@risingwavelabs/cargo-lock plz give an approve. Thanks |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.