Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): SourceExecutor minor refactor #14706

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jan 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan force-pushed the 01-22-refactor_stream_SourceExecutor_minor_refactor branch from aa77757 to 3cbc2f2 Compare January 22, 2024 01:20
Comment on lines -183 to -187
/// This function provides the ability to persist the source state
/// and needs to be invoked by the ``SourceReader`` to call it,
/// and will return the error when the dependent ``StateStore`` handles the error.
/// The caller should ensure that the passed parameters are not empty.
pub async fn take_snapshot<SS>(&mut self, states: Vec<SS>) -> StreamExecutorResult<()>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comments are verbose (and a little outdated?).

Function name set_states might be enough to describe what it does.

@xxchan xxchan requested a review from tabVersion January 22, 2024 01:25
@BugenZhao
Copy link
Member

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Wow, such a complicated topology. 😁

@stdrc
Copy link
Member

stdrc commented Jan 22, 2024

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Wow, such a complicated topology. 😁

Just curious, can Graphite support inheriting from multiple upstream branches?

Base automatically changed from 01-13-refactor_minor_refactor_on_fragment_graph_building to main February 1, 2024 05:30
@xxchan xxchan force-pushed the 01-22-refactor_stream_SourceExecutor_minor_refactor branch from 3cbc2f2 to 90fc7e5 Compare February 1, 2024 05:54
@xxchan xxchan enabled auto-merge February 1, 2024 05:55
@xxchan
Copy link
Member Author

xxchan commented Feb 1, 2024

@risingwavelabs/cargo-lock plz give an approve. Thanks

@xxchan xxchan requested a review from BugenZhao February 2, 2024 02:49
@xxchan xxchan added this pull request to the merge queue Feb 4, 2024
Merged via the queue into main with commit 829ee39 Feb 4, 2024
35 of 36 checks passed
@xxchan xxchan deleted the 01-22-refactor_stream_SourceExecutor_minor_refactor branch February 4, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants