refactor: minor refactor on fragment graph building #14560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
9 tasks
This was referenced Jan 15, 2024
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
2 times, most recently
from
b4d664b to
d6a095f
Compare
xxchan
changed the base branch from
main
to
01-19-refactor_refactor_LogicalSource
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
d6a095f to
694ebb9
Compare
9 tasks
xxchan
force-pushed
the
01-19-refactor_refactor_LogicalSource
branch
from
de2e161 to
b673a45
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
694ebb9 to
de9e090
Compare
xxchan
force-pushed
the
01-19-refactor_refactor_LogicalSource
branch
from
b673a45 to
e5eff60
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
de9e090 to
63f32da
Compare
xxchan
force-pushed
the
01-19-refactor_refactor_LogicalSource
branch
from
e5eff60 to
98ab255
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
63f32da to
faded54
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
faded54 to
4f89a84
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
4f89a84 to
b440bc0
Compare
xxchan
force-pushed
the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
from
b440bc0 to
8aedab6
Compare
9 tasks
StrikeW
approved these changes
Jan 22, 2024
BugenZhao
approved these changes
Jan 22, 2024
proto/stream_plan.proto
Outdated
Comment on lines
259
to
260
| repeated int32 upstream_column_ids = 3; | ||
| reserved "upstream_column_ids"; | ||
| reserved 3; |
There was a problem hiding this comment.
Since it was never used (so there was never a message persisted with #3), can we directly remove the field?
There was a problem hiding this comment.
Sounds good! Can you do it for me?
Comment on lines
+175
to
+180
| self.get_table() | ||
| .unwrap() | ||
| .distribution_key | ||
| .iter() | ||
| .map(|i| *i as u32) | ||
| .collect() |
There was a problem hiding this comment.
We should really have a trait converting our types from and into prost types. 😄
Base automatically changed from
01-19-refactor_refactor_LogicalSource
to
main
January 22, 2024 10:23
xxchan
commented
Feb 1, 2024
tabVersion
reviewed
Feb 1, 2024
Comment on lines
+59
to
60
| /// For shared CDC table on source, its `vec![]`, since the upstream source's output schema is fixed. | ||
| upstream_table_columns: HashMap<TableId, Vec<i32>>, |
There was a problem hiding this comment.
what does the i32 mean here
xxchan
deleted the
01-13-refactor_minor_refactor_on_fragment_graph_building
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
upstream_column_idsforCdcFilterNode. Because CDC source's schema is fixed.CompleteStreamFragmentGraph::build_helpershorter.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.