chore(storage): upgrade config #14601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
approved these changes
Jan 17, 2024
…nto li0k/test_compact_config
…nto li0k/test_compact_config
src/common/src/config.rs
Outdated
| const DEFAULT_TARGET_FILE_SIZE_BASE: u64 = 32 * 1024 * 1024; // 32MB | ||
| const DEFAULT_MAX_SUB_COMPACTION: u32 = 4; | ||
| const DEFAULT_LEVEL_MULTIPLIER: u64 = 5; | ||
| const DEFAULT_MAX_SPACE_RECLAIM_BYTES: u64 = 512 * 1024 * 1024; // 512MB; | ||
| const DEFAULT_LEVEL0_STOP_WRITE_THRESHOLD_SUB_LEVEL_NUMBER: u64 = 300; | ||
| const DEFAULT_MAX_COMPACTION_FILE_COUNT: u64 = 96; | ||
| const DEFAULT_MAX_COMPACTION_FILE_COUNT: u64 = 200; |
There was a problem hiding this comment.
Will it cause some cluster with less memory OOM ?
There was a problem hiding this comment.
I found that it did not affect tier compact, and in this PR I decided to roll it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related to #13331. The default value of ckpt is 1, which means that l0 files are generated twice as fast, so adjust the l0-related compact parameters for better performance.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.