Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.compaction_config can affect s3 request rates. #14725

Closed
kwannoel opened this issue Jan 22, 2024 · 2 comments
Closed

meta.compaction_config can affect s3 request rates. #14725

kwannoel opened this issue Jan 22, 2024 · 2 comments

Comments

@kwannoel
Copy link
Contributor

Can use this to reproduce: #14722.

When this is present:

[meta.compaction_config]
level0_tier_compact_file_number = 6
level0_overlapping_sub_level_compact_level_count = 3
level0_max_compact_file_number = 96

The tests will fail with SlowDown error from s3 (minio).

When it's not present, the tests will complete really quickly.

What's the reason this can affect the test performance?

@hzxa21
Copy link
Collaborator

hzxa21 commented Jan 23, 2024

I think it is because #13331 implicitly bumps the checkpoint frequency from ckpt every 2 barriers to ckpt every 1 barrier. This has several implications:

  1. CN's write to S3 rate is doubled
  2. Storage L0 files increasing rate is doubled
  3. With the compaction config you have pasted, compaction is triggered more aggressively because of 2.

All these can lead to an increase in S3 request rate. @Li0k has merged #14601 to modify the default compaction config accordingly. I think we missed to update the ci config, which is set explicitly rather than using default.

@Li0k Li0k modified the milestones: release-1.7, release-1.8 Mar 6, 2024
@Li0k Li0k modified the milestones: release-1.8, release-1.9 Apr 8, 2024
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants