refactor(frontend): Move some pg wire value into common and make them const #14519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
approved these changes
Jan 12, 2024
src/common/src/lib.rs
Outdated
Comment on lines
99
to
100
| /// Shows the server-side character set encoding. At present, this parameter can be shown but not set, because the encoding is determined at database creation time. | ||
| pub const CLIENT_ENCODING: &str = "UTF8"; |
There was a problem hiding this comment.
The doc comment does not match the name. Let's rename it to SERVER_ENCODING and add "it is also the default for CLIENT_ENCODING"
https://www.postgresql.org/docs/16/runtime-config-preset.html#GUC-SERVER-ENCODING
https://www.postgresql.org/docs/16/runtime-config-client.html#GUC-CLIENT-ENCODING
| @@ -107,5 +117,8 @@ macro_rules! git_sha { | |||
| pub const GIT_SHA: &str = git_sha!("GIT_SHA"); | |||
|
|
|||
| pub fn current_cluster_version() -> String { | |||
| format!("PostgreSQL 9.5-RisingWave-{} ({})", RW_VERSION, GIT_SHA) | |||
| format!( | |||
| "PostgreSQL {}-RisingWave-{} ({})", | |||
There was a problem hiding this comment.
@hzxa21 FYI there would be an extra .0 starting next release
- PostgreSQL 9.5-RisingWave-1.6.0 (abc)
+ PostgreSQL 9.5.0-RisingWave-1.7.0 (def)
yufansong
changed the title
Little-Wallace
pushed a commit
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #11265
current_cluster_versionfunction which used infunction / streaming job / ddl controllerwhich should get from theConfigMap.ParameterStatus, we hard code theserver version / client encoding / StandardConformingString / ApplicationName.This PR try to refactor the above two parts.
ConfigMapinto common and make they as pub const. Use this const when initialize theConfigMap.ParameterStatusfrom thesession_config. But we use const value to initsession_config, so we directly use the const forParameterStatus. The same logic forcurrent_cluster_versionChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.