Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate PostgreSQL version constant #11265

Closed
xiangjinwu opened this issue Jul 27, 2023 · 2 comments · Fixed by #14519
Closed

refactor: consolidate PostgreSQL version constant #11265

xiangjinwu opened this issue Jul 27, 2023 · 2 comments · Fixed by #14519
Assignees
Milestone

Comments

@xiangjinwu
Copy link
Contributor

BeParameterStatusMessage::ServerVersion("9.5.0"),

#[educe(Default(expression = "ConfigString::<SERVER_VERSION>(String::from(\"9.5.0\"))"))]

type ServerVersionNum = ConfigI32<SERVER_VERSION_NUM, 90_500>;

"PostgreSQL 9.5-RisingWave-{} ({})",

@github-actions github-actions bot added this to the release-1.1 milestone Jul 27, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.1, release-1.2 Aug 2, 2023
@fuyufjh fuyufjh modified the milestones: release-1.3, release-1.4 Oct 10, 2023
@yufansong yufansong self-assigned this Oct 17, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.4, release-1.5 Nov 8, 2023
@xiangjinwu xiangjinwu modified the milestones: release-1.5, release-1.6 Dec 6, 2023
@xiangjinwu
Copy link
Contributor Author

  • The frontend version() function now binds to risingwave_common::current_cluster_version
  • The pgwire implementation shall read from session.config rather than hardcoding, for all ParameterStatus message not limited to server_version.

@xiangjinwu xiangjinwu modified the milestones: release-1.6, release-1.7 Jan 9, 2024
@yufansong
Copy link
Member

yufansong commented Jan 11, 2024

Disscussed offline, 2 action needed:

  1. function / streaming job / ddl controller should get version from the same place, which currently is current_cluster_version. Need to set a const in common as the single source of truth. All previous and the ConfigMap should read from there: function/streaming/ddl -> current_cluster_version -> hardcode const in common <- ConfigMap <- pgwire/show. Need to figure out how to read const in ConfigMap
  2. Need add a code path in pgwire for ParameterStatus, server version / client encoding / StandardConformingString / ApplicationName need read from config map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants