Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): display back-pressure on fragment graph #14446

Merged
merged 8 commits into from
Jan 10, 2024
Merged

feat(dashboard): display back-pressure on fragment graph #14446

merged 8 commits into from
Jan 10, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jan 9, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #13481 for backgrounds:

  • Dynamic color and width based on the back-pressure rate. Hover over the edge to reveal the actual value.
    image
  • Add an "external" edge if there's upstream MV, which can help developers to investigate performance issue among multiple MVs.
    image

TODO:

  • What should be the proper time range for sampling the back-pressure rate?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

yezizp2012
yezizp2012 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BugenZhao
show tooltip
1204697 
Signed-off-by: Bugen Zhao <[email protected]>
stdrc
stdrc approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so successful to me!

@BugenZhao BugenZhao added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 7a8133a Jan 10, 2024
31 of 32 checks passed
@BugenZhao BugenZhao deleted the bz/dashboard-back-pressure-on-graph branch January 10, 2024 06:22
@BugenZhao BugenZhao mentioned this pull request Jan 11, 2024
Merged
4 tasks
@cyliu0 cyliu0 mentioned this pull request Jan 16, 2024
Closed
@BugenZhao BugenZhao mentioned this pull request Jan 17, 2024
Closed
8 tasks
@fuyufjh fuyufjh mentioned this pull request Jan 30, 2024
Merged
9 tasks
@BugenZhao BugenZhao mentioned this pull request Feb 23, 2024
Open
@BugenZhao BugenZhao mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yezizp2012 yezizp2012 yezizp2012 approved these changes

@stdrc stdrc stdrc approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@xxchan xxchan Awaiting requested review from xxchan

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BugenZhao @stdrc @yezizp2012