feat(dashboard): back-pressure rate on stream graph in Grafana #13422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 4441 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 1951 | 2 | 2488 | 0 |
Click to see the invalid file list
- src/utils/flowchart/src/lib.rs
- src/utils/flowchart/src/main.rs
| @@ -0,0 +1,201 @@ | |||
| use std::collections::{BTreeMap, BTreeSet, HashMap}; | |||
There was a problem hiding this comment.
Suggested change
| use std::collections::{BTreeMap, BTreeSet, HashMap}; | |
| // Copyright 2023 RisingWave Labs | |
| // | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| // See the License for the specific language governing permissions and | |
| // limitations under the License. | |
| use std::collections::{BTreeMap, BTreeSet, HashMap}; |
| @@ -0,0 +1,3 @@ | |||
| fn main() { | |||
There was a problem hiding this comment.
Suggested change
| fn main() { | |
| // Copyright 2023 RisingWave Labs | |
| // | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| // See the License for the specific language governing permissions and | |
| // limitations under the License. | |
| fn main() { |
Signed-off-by: Bugen Zhao <[email protected]>
fuyufjh
reviewed
Nov 15, 2023
| "show": False, | ||
| "stats": ["mean", "last", "min", "max", "sum"], | ||
| }, | ||
| "contentUrl": "http://localhost:5691/api/flowchart/table/${table}", |
There was a problem hiding this comment.
Cool! In this way the Grafana can display a dynamic graph, generated by the Rust code
There was a problem hiding this comment.
Yeah, but I find limitations. 😕 The requests seem to be sent from the browser, so the connectivity might be a problem.
There was a problem hiding this comment.
The JSON data source might help to fetch the flowchart content, which supports sending requests from the server:
This was referenced Nov 16, 2023
|
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
Superseded by #14446. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
So that we can quickly find the bottleneck of a stream job. Inter-table flow chart is coming soon.
Preview:
Compared with #12397:
Pros:
Cons:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.