feat(dml): sent dml data from the same session to a fixed worker node/channel #14380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and let group batch perserve transaction order
chenzl25
commented
Jan 5, 2024
Comment on lines
-99
to
+100
| .get((txn_id % len as u64) as usize) | ||
| .get((session_id % len as u32) as usize) |
There was a problem hiding this comment.
Use session id instead of txn_id to choose channel so that we can preserve transaction order in the same session
src/frontend/src/scheduler/local.rs
Outdated
Comment on lines
584
to
586
| candidates.choose(&mut rand::thread_rng()).unwrap().clone() | ||
| candidates | ||
| .get(stage.session_id.0 as usize % candidates.len()) | ||
| .context("no available worker node for dml")? | ||
| .clone() |
There was a problem hiding this comment.
Choose a worker based on session id.
Comment on lines
709
to
713
| return Ok(Some( | ||
| candidates | ||
| .get(self.stage.session_id.0 as usize % candidates.len()) | ||
| .context("no available worker node for dml")? | ||
| .clone(), |
There was a problem hiding this comment.
Choose a worker based on session id.
Comment on lines
+196
to
+208
| if !batch_group.is_empty() { | ||
| let vec = mem::take(&mut batch_group); | ||
| for chunk in vec { | ||
| for (op, row) in chunk.rows() { | ||
| if let Some(chunk) = builder.append_row(op, row) { | ||
| yield Message::Chunk(chunk); | ||
| } | ||
| } | ||
| } | ||
| if let Some(chunk) = builder.take() { | ||
| yield Message::Chunk(chunk); | ||
| } | ||
| } |
There was a problem hiding this comment.
Always preserve transaction orders even with batch group optimization
BugenZhao
reviewed
Jan 5, 2024
BugenZhao
reviewed
Jan 5, 2024
chenzl25
deleted the
dylan/preserve_transaction_order_in_the_same_session
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and let group batch perserve transaction order
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.