Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug / known issue: inserts may be disordered even on one session #7213

Closed
fuyufjh opened this issue Jan 5, 2023 · 5 comments
Closed

bug / known issue: inserts may be disordered even on one session #7213

fuyufjh opened this issue Jan 5, 2023 · 5 comments
Labels
type/bug Something isn't working

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Jan 5, 2023

Describe the bug

Here a random write channel will be picked.

let (index, tx) = core
.changes_txs
.iter()
.enumerate()
.choose(&mut rand::thread_rng())
.context("no available table reader in streaming source executors")?;

As a result, even in one session, DML statements may be reordered regarding the time that they leave the write channel.

To Reproduce

Just a technical analysis.

Expected behavior

Writes in one session should happen in order.

Additional context

No response

@fuyufjh fuyufjh added the type/bug Something isn't working label Jan 5, 2023
@github-actions github-actions bot added this to the release-0.1.16 milestone Jan 5, 2023
@lmatz
Copy link
Contributor

lmatz commented Jan 6, 2023

#7134,

And another question is that whether we ignore an insert with the same pk
or let it overwrite the previous one
or both make sense so user decide

@fuyufjh
Copy link
Member Author

fuyufjh commented Jan 14, 2023

#7134,

And another question is that whether we ignore an insert with the same pk or let it overwrite the previous one or both make sense so user decide

I once discussed with @st1page.

@st1page was considering adding a table-level option to control whether a new update should override. (upsert or ignore)

My idea is to always do upsert, similar to Flink's updatable stream.

@fuyufjh fuyufjh removed this from the release-0.1.16 milestone Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@st1page
Copy link
Contributor

st1page commented Apr 3, 2023

FYI: risingwavelabs/rfcs#48

@xxchan
Copy link
Member

xxchan commented Oct 17, 2024

fixed by #14380

@xxchan xxchan closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants