feat(dashboard): allow specifying API endpoint for development #14361
+116
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Jan 4, 2024
Comment on lines
+36
to
+39
| const [apiEndpoint, saveApiEndpoint] = useLocalStorage( | ||
| API_ENDPOINT_KEY, | ||
| DEFAULT_API_ENDPOINT | ||
| ) |
There was a problem hiding this comment.
The endpoint will be stored in the local storage of the browser.
Comment on lines
+28
to
+29
| export const DEFAULT_API_ENDPOINT: string = | ||
| process.env.NODE_ENV === "production" ? PROD_API_ENDPOINT : MOCK_API_ENDPOINT |
There was a problem hiding this comment.
By default we still use the mock_server for development and /api for production. Developers may set it to http://localhost:5691/api so that they can develop dashboard with a real local cluster.
| @@ -20,16 +20,6 @@ | |||
| */ | |||
| const nextConfig = { | |||
| trailingSlash: true, | |||
|
|
|||
| rewrites: () => { | |||
There was a problem hiding this comment.
No need for rewrites now as we directly send requests to the mock server with CORS allowed.
Signed-off-by: Bugen Zhao <[email protected]>
xxchan
approved these changes
Jan 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Allow specifying API endpoint for development. Previously the input field is even static. 😄
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.