Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pubsub auth #14360

Merged
merged 5 commits into from
Jan 4, 2024
Merged

fix: pubsub auth #14360

merged 5 commits into from
Jan 4, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Jan 4, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

checkout from #13918
and fix format issue

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

dermasmid and others added 4 commits December 11, 2023 12:09
@dermasmid
pubsub: fix auth
d99c09e
@dermasmid @xxchan
Update client.rs
e0917f4 
Co-authored-by: xxchan <[email protected]>
@dermasmid @xxchan
Update reader.rs
e1ef431 
Co-authored-by: xxchan <[email protected]>
@tabVersion
refactor: Refactor unnecessary initialization in Google Pub/Sub reader
7221c85 
- Remove unnecessary line of code initializing `_columns` in `reader.rs`

Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion requested a review from xxchan January 4, 2024 07:22
@tabVersion tabVersion enabled auto-merge January 4, 2024 07:22
@tabVersion tabVersion mentioned this pull request Jan 4, 2024
Closed
9 tasks
@tabVersion tabVersion changed the title pubsub: fix auth fix: pubsub auth Jan 4, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Jan 4, 2024
@tabVersion tabVersion added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 6ded264 Jan 4, 2024
27 of 28 checks passed
@tabVersion tabVersion deleted the tab/fix-format branch January 4, 2024 08:24
Li0k pushed a commit that referenced this pull request Jan 10, 2024
@tabVersion @dermasmid
@xxchan @Li0k
fix: pubsub auth (#14360)
f3eafad 
Signed-off-by: tabVersion <[email protected]>
Co-authored-by: cheskel <[email protected]>
Co-authored-by: xxchan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabVersion @xxchan @dermasmid