fix: pubsub auth #13918
Closed
fix: pubsub auth #13918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
reviewed
Dec 12, 2023
yufansong
reviewed
Dec 12, 2023
Co-authored-by: xxchan <[email protected]>
Co-authored-by: xxchan <[email protected]>
|
It seems you have some format problem and cannot pass the format checker. Please correct it. |
|
Let me commit to their branch to fix this |
|
resolved in #14357 |
|
sorry that I cannot push to your original branch, checkout to #14360 to merge the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
While trying to test risingwave with gcp pubsub, i was not able to get it to connect to GCP, failing with a error:
This is dummy token source provider. you can use 'google_cloud_default' crate.looking here https://github.com/yoshidan/google-cloud-rust/tree/main/pubsub it seems like we need to add
with_auth, so i did, its possible that its a recent change on their endChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.