fix(expr): fix SOME/ALL/ANY expression

[wangrunji0408]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #14214, which was introduced by #13402.

 dev=> select a = any(b) from (values (1, array[1,2]), (1, array[2,1])) as t(a, b);
  ?column? 
 ----------
  t
- f
+ t
 (2 rows)

 dev=> select a = all(b) from (values (1, array[2,3]), (1, array[1])) as t(a, b);
  ?column? 
 ----------
  f
- f
+ t
 (2 rows)

When short-circuit occurred, the resolve_bools function did not consume all items in the input iterator, causing subsequent booleans to be misaligned.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Fixes the correctness of SOME/ALL/ANY expressions. The fix introduces a breaking change for versions from v1.5.0 to v1.5.3. It is recommended to drop and recreate any materialized views that contain SOME/ALL/ANY expressions.

[chenzl25]

LGTM, thanks

[BugenZhao]

I'm worrying that the fix will lead to similar compatibility issue like #13890. 😕

[BugenZhao]

So the actual bug is that we mistakenly expect resolve_bools to exhaust the passed-in iterator, right? This is quite subtle. 🤣 Could you please add some comments to elaborate this?

[wangrunji0408]

Yes. I didn't realize the passed-in iterator is actually a reference. This is a bad practice. 🤪

[wangrunji0408]

CI found a bug in EOWC. Looks like unrelated to this PR. cc @stdrc

https://buildkite.com/risingwavelabs/pull-request/builds/38146#018ca931-39a8-44af-8d77-40cb0b2cc022/261-550

failed to run `e2e_test/streaming/temporal_join/temporal_join_watermark.slt`
Caused by:
    query result mismatch:
    [SQL] select * from eowc_mv;
    [Diff] (-expected|+actual)
    -   2023-09-14 06:00:00+00:00 1
    at e2e_test/streaming/temporal_join/temporal_join_watermark.slt:42