Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): support streaming make_timestamptz #13702

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Nov 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, followup of #13647.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

make_timestamptz (year int, month int, day int, hour int, min int, sec double precision [, timezone text ]) → timestamptz
Create timestamp with time zone from year, month, day, hour, minute and seconds fields (negative years signify BC). If timezone is not specified, the current time zone is used; the examples assume the session time zone is Europe/London.
make_timestamptz(2013, 7, 15, 8, 15, 23.5) → 2013-07-15 08:15:23.500+01:00
make_timestamptz(2013, 7, 15, 8, 15, 23.5, 'America/New_York') → 2013-07-15 13:15:23.500+01:00

@KeXiangWang KeXiangWang requested a review from a team as a code owner November 29, 2023 01:26
@KeXiangWang
Copy link
Contributor Author

Currently, blocked by #13647.
Will perform more compatibility tests and failover tests later.

@KeXiangWang KeXiangWang force-pushed the wkx/streaming-make-timestamptz branch from 51feb6c to 3b053c3 Compare November 29, 2023 02:24
@BugenZhao BugenZhao changed the base branch from main to wkx/distributed-make-timestamptz November 29, 2023 12:07
Base automatically changed from wkx/distributed-make-timestamptz to main November 30, 2023 19:52
src/expr/macro/src/lib.rs Outdated Show resolved Hide resolved
proto/stream_plan.proto Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (e056c66) 68.34% compared to head (c387322) 68.34%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/frontend/src/scheduler/distributed/stage.rs 27.27% 8 Missing ⚠️
src/meta/src/model/stream.rs 0.00% 6 Missing ⚠️
src/batch/src/rpc/service/task_service.rs 0.00% 5 Missing ⚠️
src/meta/src/rpc/ddl_controller.rs 0.00% 4 Missing ⚠️
src/expr/core/src/expr_context.rs 62.50% 3 Missing ⚠️
src/batch/src/task/task_manager.rs 71.42% 2 Missing ⚠️
src/rpc_client/src/compute_client.rs 0.00% 2 Missing ⚠️
src/stream/src/task/stream_manager.rs 0.00% 2 Missing ⚠️
src/batch/src/execution/grpc_exchange.rs 0.00% 1 Missing ⚠️
src/meta/model_v2/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13702      +/-   ##
==========================================
- Coverage   68.34%   68.34%   -0.01%     
==========================================
  Files        1528     1528              
  Lines      263278   263282       +4     
==========================================
- Hits       179947   179928      -19     
- Misses      83331    83354      +23     
Flag Coverage Δ
rust 68.34% <64.21%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuyufjh fuyufjh requested review from stdrc and BugenZhao December 5, 2023 03:55
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KeXiangWang KeXiangWang force-pushed the wkx/streaming-make-timestamptz branch from f93c225 to 49068da Compare December 6, 2023 04:25
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are 2 parts that could have been separated to improve readability:

  • 13 files in batch/expr/frontend/rpc_client contain the ExprContext renaming and expr_context_scope helper.
  • 10 files in meta/stream contain the support in streaming.

It is okay not to split if the above summary is accurate. However, if there are any changes in the first part that actually contribute to the streaming support and I missed it, it is a strong signal that they are better separated to 1 refactor PR and 1 feature PR.

Cargo.lock Outdated Show resolved Hide resolved
e2e_test/batch/basic/make_timestamptz.slt.part Outdated Show resolved Hide resolved
src/meta/model_v2/src/actor.rs Outdated Show resolved Hide resolved
@xiangjinwu

This comment was marked as outdated.

@KeXiangWang KeXiangWang force-pushed the wkx/streaming-make-timestamptz branch from 49068da to 89ef68c Compare December 7, 2023 20:57
@KeXiangWang KeXiangWang force-pushed the wkx/streaming-make-timestamptz branch from 89ef68c to c387322 Compare December 7, 2023 21:07
@KeXiangWang KeXiangWang enabled auto-merge December 7, 2023 21:37
@KeXiangWang KeXiangWang added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit f93175c Dec 7, 2023
42 of 44 checks passed
@KeXiangWang KeXiangWang deleted the wkx/streaming-make-timestamptz branch December 7, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants