-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): support streaming make_timestamptz #13702
Conversation
Currently, blocked by #13647. |
51feb6c
to
3b053c3
Compare
3b053c3
to
1219100
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13702 +/- ##
==========================================
- Coverage 68.34% 68.34% -0.01%
==========================================
Files 1528 1528
Lines 263278 263282 +4
==========================================
- Hits 179947 179928 -19
- Misses 83331 83354 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f93c225
to
49068da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are 2 parts that could have been separated to improve readability:
- 13 files in batch/expr/frontend/rpc_client contain the
ExprContext
renaming andexpr_context_scope
helper. - 10 files in meta/stream contain the support in streaming.
It is okay not to split if the above summary is accurate. However, if there are any changes in the first part that actually contribute to the streaming support and I missed it, it is a strong signal that they are better separated to 1 refactor PR and 1 feature PR.
This comment was marked as outdated.
This comment was marked as outdated.
49068da
to
89ef68c
Compare
89ef68c
to
c387322
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, followup of #13647.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note