Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stream): rename StreamEnvironment to StreamContext #13863

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Dec 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As mentioned in #13702 (comment), in stream_manager, we have two different data structure both called StreamEnvironment, which is confusing. This PR rename one to StreamContext to avoid the ambiguity.

Simply renaming one message should not cause compatiblity issues. As protobuf use type and serial number to recognize one message.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh
Copy link
Member

fuyufjh commented Dec 8, 2023

Simply renaming one message should not cause compatiblity issues. As protobuf use type and serial number to recognize one message.

That's true. But let me run a compatibility test just in case.

@fuyufjh fuyufjh added the ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 920 lines in your changes are missing coverage. Please review.

Comparison is base (b87bcc3) 68.33% compared to head (23d1b41) 68.12%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/meta/src/rpc/ddl_controller.rs 0.00% 232 Missing ⚠️
src/frontend/src/handler/create_sink.rs 14.96% 216 Missing ⚠️
src/meta/src/barrier/command.rs 8.82% 93 Missing ⚠️
src/meta/service/src/ddl_service.rs 0.00% 63 Missing ⚠️
src/meta/src/manager/catalog/mod.rs 18.64% 48 Missing ⚠️
src/stream/src/executor/mod.rs 22.72% 34 Missing ⚠️
src/meta/src/stream/stream_manager.rs 34.78% 30 Missing ⚠️
src/connector/src/sink/table.rs 0.00% 23 Missing ⚠️
src/meta/src/model/stream.rs 21.42% 22 Missing ⚠️
src/frontend/src/catalog/catalog_service.rs 0.00% 20 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13863      +/-   ##
==========================================
- Coverage   68.33%   68.12%   -0.22%     
==========================================
  Files        1528     1529       +1     
  Lines      263343   264142     +799     
==========================================
- Hits       179958   179944      -14     
- Misses      83385    84198     +813     
Flag Coverage Δ
rust 68.12% <26.40%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeXiangWang KeXiangWang force-pushed the wkx/rename-stream-environment branch from 78181f1 to 7b85fa2 Compare December 10, 2023 00:04
@KeXiangWang KeXiangWang added this pull request to the merge queue Dec 10, 2023
Merged via the queue into main with commit 7b6bbf3 Dec 10, 2023
10 of 13 checks passed
@KeXiangWang KeXiangWang deleted the wkx/rename-stream-environment branch December 10, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants