Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust default large query memory #13686

Merged
merged 2 commits into from
Dec 1, 2023
Merged

chore: Adjust default large query memory #13686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
139db56
chore: Adjust default large query memory
liurenjie1024 Nov 28, 2023
de7fdcc
Merge branch 'main' into renjie/issue-13506
liurenjie1024 Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/compute/src/memory/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const STORAGE_SHARED_BUFFER_MEMORY_PROPORTION: f64 = 0.3;
const STORAGE_DEFAULT_HIGH_PRIORITY_BLOCK_CACHE_RATIO: usize = 50;

/// Since the new feature prefetch does not cost much memory, we set a large value by default for performance. If we meet OOM during long time batch query, we shall reduce this configuration.
const STORAGE_DEFAULT_LARGE_QUERY_MEMORY_USAGE_MB: usize = 32 * 1024;
const STORAGE_DEFAULT_LARGE_QUERY_MEMORY_USAGE_MB: usize = 2 * 1024;

/// Each compute node reserves some memory for stack and code segment of processes, allocation
/// overhead, network buffer, etc. based on `SYSTEM_RESERVED_MEMORY_PROPORTION`. The reserve memory
Expand Down Expand Up @@ -118,6 +118,7 @@ pub fn storage_memory_config(
);

let total_calculated_mb = block_cache_capacity_mb
+ large_query_memory_usage_mb
+ meta_cache_capacity_mb
+ shared_buffer_capacity_mb
+ data_file_cache_ring_buffer_capacity_mb
Expand Down
Loading