Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust default large query memory #13686

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Nov 28, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #13506

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2db9c8e) 68.19% compared to head (de7fdcc) 68.21%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/jni_core/src/hummock_iterator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13686      +/-   ##
==========================================
+ Coverage   68.19%   68.21%   +0.01%     
==========================================
  Files        1523     1523              
  Lines      262210   262265      +55     
==========================================
+ Hits       178819   178903      +84     
+ Misses      83391    83362      -29     
Flag Coverage Δ
rust 68.21% <98.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenzl25
Copy link
Contributor

chenzl25 commented Nov 28, 2023

IIRC, this PR #13558 will deprecate this configuration.

@liurenjie1024
Copy link
Contributor Author

IIRC, this PR #13558 will deprecate this configuration.

I think they are not conflicting. #13558 will fix this in each executor, and we can merge this first to solve the potential oom issue.

@lmatz
Copy link
Contributor

lmatz commented Nov 29, 2023

just bump to see if reviewers agree with merging this PR?
the backfill/batch scan perf is still blocked by this OOM issue

@liurenjie1024
Copy link
Contributor Author

CC @chenzl25 @hzxa21 @Little-Wallace

@liurenjie1024 liurenjie1024 added this pull request to the merge queue Nov 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 30, 2023
@liurenjie1024 liurenjie1024 added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit da79ff5 Dec 1, 2023
26 of 27 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-13506 branch December 1, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants