Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): make _rw_key not hidden column #13521

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Nov 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #13503

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page requested review from hzxa21 and tabVersion November 20, 2023 09:52
@github-actions github-actions bot added the type/fix Bug fix label Nov 20, 2023
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes.

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da92087) 68.39% compared to head (ab21e30) 68.38%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13521      +/-   ##
==========================================
- Coverage   68.39%   68.38%   -0.02%     
==========================================
  Files        1508     1508              
  Lines      259670   259670              
==========================================
- Hits       177604   177576      -28     
- Misses      82066    82094      +28     
Flag Coverage Δ
rust 68.38% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st1page
Copy link
Contributor Author

st1page commented Nov 20, 2023

change some e2e test to specify the columns without _rw_key. It is just workaround and the key column will be added after we introduce the grammar to declare if user need the key.

@st1page st1page added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit ed957e6 Nov 21, 2023
28 of 29 checks passed
@st1page st1page deleted the sts/make_rw_key_not_hidden branch November 21, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: unable to insert data into an upsert avro table
4 participants