fix: revert #13278 & #13390 for include syntax #13785
Merged
+111
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c78170
tabVersion
changed the title
|
please review with caution, there is not much time left before releasing |
keven-huang
reviewed
Dec 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13785 +/- ##
==========================================
+ Coverage 68.19% 68.24% +0.04%
==========================================
Files 1524 1524
Lines 262232 262186 -46
==========================================
+ Hits 178829 178921 +92
+ Misses 83403 83265 -138
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM, I didn't find error. |
keven-huang
approved these changes
Dec 4, 2023
st1page
approved these changes
Dec 4, 2023
xxchan
reviewed
Dec 4, 2023
I guess yes but this PR LGTM because we have determine deprecate the cyrrent implementation and it will be replaced by "include key as" ater. |
|
may also relate to #13521 |
tabVersion
added a commit
that referenced
this pull request
Dec 5, 2023
Co-authored-by: Bohan Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
the motivation of the pr is to correct the behavior about when to add a column.
now we have a rfc about introducing columns not coming from value part risingwavelabs/rfcs#79 and will be implemented in #13707
now deprecating the hot fix related pr.
If any cluster cannot be recovered please rebuild the sources/tables with
format plainChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.