-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): add retry on UDF connection error #13375
Conversation
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
00f5a8f
to
c8e0b06
Compare
Signed-off-by: Runji Wang <[email protected]>
e2e_test/udf/retry_python.slt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we should also test failing 5 times?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13375 +/- ##
==========================================
- Coverage 68.31% 68.30% -0.01%
==========================================
Files 1523 1523
Lines 261730 261739 +9
==========================================
- Hits 178794 178793 -1
- Misses 82936 82946 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds retries on UDF connection errors, using exponential backoff.
PS. I have tried
tokio_retry
but it blocks after reaching the limit number of retries without returning an error. I'm not sure if this is an issue withtokio_retry
itself. Just record here.Checklist
./risedev check
(or alias,./risedev c
)Documentation