Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): add retry on UDF connection error #13375

Merged
merged 7 commits into from
Nov 28, 2023
Merged

fix(udf): add retry on UDF connection error #13375

merged 7 commits into from
Nov 28, 2023

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Nov 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds retries on UDF connection errors, using exponential backoff.

PS. I have tried tokio_retry but it blocks after reaching the limit number of retries without returning an error. I'm not sure if this is an issue with tokio_retry itself. Just record here.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 requested a review from a team as a code owner November 13, 2023 03:39
@github-actions github-actions bot added the type/fix Bug fix label Nov 13, 2023
src/udf/src/external.rs Outdated Show resolved Hide resolved
src/udf/src/external.rs Show resolved Hide resolved
Signed-off-by: Runji Wang <[email protected]>
src/udf/src/external.rs Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we should also test failing 5 times?

@stdrc stdrc requested a review from BugenZhao November 23, 2023 07:31
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ce73e80) 68.31% compared to head (b68ac23) 68.30%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/udf/src/error.rs 0.00% 8 Missing ⚠️
src/udf/src/external.rs 0.00% 6 Missing ⚠️
src/expr/core/src/expr/expr_udf.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13375      +/-   ##
==========================================
- Coverage   68.31%   68.30%   -0.01%     
==========================================
  Files        1523     1523              
  Lines      261730   261739       +9     
==========================================
- Hits       178794   178793       -1     
- Misses      82936    82946      +10     
Flag Coverage Δ
rust 68.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2023
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into main with commit ff90f8c Nov 28, 2023
28 of 29 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/udf-retry branch November 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants