Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(streaming): memory-size-based back-pressure in exchange" #13822

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

wangrunji0408
Copy link
Contributor

Reverts #13775 due to performance degradation.

@MrCroxx
Copy link
Contributor

MrCroxx commented Dec 6, 2023

Some contexts: #13775 may cause the actor throughputs of the same fragment are not balanced.

wo/w #13375:

image

@MrCroxx MrCroxx enabled auto-merge December 6, 2023 06:13
@MrCroxx MrCroxx added this pull request to the merge queue Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1d99124) 68.23% compared to head (6efe5ce) 68.29%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/stream/src/executor/exchange/input.rs 0.00% 1 Missing ⚠️
src/stream/src/executor/exchange/permit.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13822      +/-   ##
==========================================
+ Coverage   68.23%   68.29%   +0.06%     
==========================================
  Files        1525     1525              
  Lines      262308   262307       -1     
==========================================
+ Hits       178975   179139     +164     
+ Misses      83333    83168     -165     
Flag Coverage Δ
rust 68.29% <88.88%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit a8aa905 Dec 6, 2023
30 of 31 checks passed
@MrCroxx MrCroxx deleted the revert-13775-wrj/memory-based-channel-permit branch December 6, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants