Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a docker compose file for standalone mode #13233

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Nov 3, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

add a docker-compose file for standalone mode. Will update the docs.

resolve #12538

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz requested a review from kwannoel November 3, 2023 06:33
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new docker-compose-standalone.yaml, I think we can place the existing docker-compose.yaml, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.

But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.

@kwannoel
Copy link
Contributor

kwannoel commented Nov 3, 2023

Thanks!

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #13233 (1ebb91e) into main (57f75da) will increase coverage by 0.06%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13233      +/-   ##
==========================================
+ Coverage   68.06%   68.13%   +0.06%     
==========================================
  Files        1515     1515              
  Lines      257111   257111              
==========================================
+ Hits       175013   175192     +179     
+ Misses      82098    81919     -179     
Flag Coverage Δ
rust 68.13% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@lmatz lmatz added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 31bf68e Nov 3, 2023
15 checks passed
@lmatz lmatz deleted the lz/standalone branch November 3, 2023 07:30
@hengm3467
Copy link
Contributor

LGTM

Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new docker-compose-standalone.yaml, I think we can place the existing docker-compose.yaml, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.

But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.

@lmatz Was this PR included in v1.4? I don't see it in the comparison list (1.3-rc - 1.4-rc). And I assume using the standalone mode in Docker by default is not done yet. Correct? Thanks.

@lmatz
Copy link
Contributor Author

lmatz commented Nov 8, 2023

LGTM
Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new docker-compose-standalone.yaml, I think we can place the existing docker-compose.yaml, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.
But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.

@lmatz Was this PR included in v1.4? I don't see it in the comparison list (1.3-rc - 1.4-rc). And I assume using the standalone mode in Docker by default is not done yet. Correct? Thanks.

Hi @hengm3467,
It is not ready yet, and not included in v1.4. The default deployment of docker compose is still non-standalone mode.

We will need to do some tests first, details in
https://github.com/risingwavelabs/risingwave-docs/issues/1187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standalone mode in docker-compose.yml
4 participants