-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a docker compose file for standalone mode #13233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new docker-compose-standalone.yaml
, I think we can place the existing docker-compose.yaml
, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.
But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.
Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #13233 +/- ##
==========================================
+ Coverage 68.06% 68.13% +0.06%
==========================================
Files 1515 1515
Lines 257111 257111
==========================================
+ Hits 175013 175192 +179
+ Misses 82098 81919 -179
Flags with carried forward coverage won't be shown. Click here to find out more. see 17 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@lmatz Was this PR included in v1.4? I don't see it in the comparison list (1.3-rc - 1.4-rc). And I assume using the standalone mode in Docker by default is not done yet. Correct? Thanks. |
Hi @hengm3467, We will need to do some tests first, details in |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add a docker-compose file for standalone mode. Will update the docs.
resolve #12538
Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.