-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standalone
as default docker compose mode
#13235
Comments
cc: @huangjw806 could you help take a look after In short, we want to rename the And rename the current |
Does that mean our integration tests also need to use standalone mode or still use |
use standalone mode. We will recommend users to use standalone mode by default once it is integrated into the test pipelines and we found no problem |
@lmatz After change the integration pipeline to use standalone mode, all logs printed by different components (cn, compactor, etc) are interleaved. And we cannot easily grep by component name, since there is no component name prefix in the log only crate prefix. That makes it hard to analyze the failed test case. So what about change the docker-compose.yml of integration test to inherit from |
Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new
docker-compose-standalone.yaml
, I think we can place the existingdocker-compose.yaml
, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.
Originally posted by @fuyufjh in #13233 (review)
The text was updated successfully, but these errors were encountered: