Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standalone as default docker compose mode #13235

Closed
lmatz opened this issue Nov 3, 2023 · 4 comments
Closed

Use standalone as default docker compose mode #13235

lmatz opened this issue Nov 3, 2023 · 4 comments
Assignees
Milestone

Comments

@lmatz
Copy link
Contributor

lmatz commented Nov 3, 2023

          LGTM

Actually, I think we can go one step further and use standalone mode in Docker by default. That is, instead of adding a new docker-compose-standalone.yaml, I think we can place the existing docker-compose.yaml, because that a user preferring docker-compose than k8s must want to deploy RW in a single machine.

But this may involve some modifications to test pipeline as well. Since the v1.4 is coming soon, we may do it later.

Originally posted by @fuyufjh in #13233 (review)

@github-actions github-actions bot added this to the release-1.5 milestone Nov 3, 2023
@lmatz
Copy link
Contributor Author

lmatz commented Nov 3, 2023

cc: @huangjw806

could you help take a look after v1.4 is released?

In short, we want to rename the docker-compose-standalone.yaml as docker-compose.yml (the default one triggered when user docker compose under the docker folder), but worrying that it may mess up test pipelines on Buildkite.

And rename the current docker-compose.yml to docker-compose-distributed.yml

@huangjw806
Copy link
Contributor

huangjw806 commented Nov 6, 2023

In short, we want to rename the docker-compose-standalone.yaml as docker-compose.yml

Does that mean our integration tests also need to use standalone mode or still use docker-compose-distributed.yml?

@lmatz
Copy link
Contributor Author

lmatz commented Nov 6, 2023

use standalone mode.

We will recommend users to use standalone mode by default once it is integrated into the test pipelines and we found no problem

@StrikeW
Copy link
Contributor

StrikeW commented Dec 14, 2023

use standalone mode.

We will recommend users to use standalone mode by default once it is integrated into the test pipelines and we found no problem

@lmatz After change the integration pipeline to use standalone mode, all logs printed by different components (cn, compactor, etc) are interleaved. And we cannot easily grep by component name, since there is no component name prefix in the log only crate prefix. That makes it hard to analyze the failed test case.

So what about change the docker-compose.yml of integration test to inherit from docker-compose-distributed.yml instead of docker-compose.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants