-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate backfill tests to deterministic integration tests #13219
Conversation
bd82f41
to
1e4de06
Compare
1e4de06
to
a225173
Compare
20cf09a
to
ee9abfd
Compare
Now just fixing the |
02b0d23
to
e168f22
Compare
PTAL again @chenzl25 @BugenZhao |
The PR description needs to be changed as well. |
A related issue #9178 |
Codecov Report
@@ Coverage Diff @@
## main #13219 +/- ##
==========================================
- Coverage 68.13% 68.06% -0.08%
==========================================
Files 1515 1515
Lines 257111 257114 +3
==========================================
- Hits 175191 175011 -180
- Misses 81920 82103 +183
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
a45edbf
to
3d17200
Compare
3d17200
to
ba023ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Part of #12957
trace
level logging ofno_shuffle_backfill
to debug some bug.FlowControlExecutor
, previously it used to wrong number to indicate cardinality.Now upstream data could have been checkpointed several epoch's ago, so it will return the full data.
But the latest snapshot data being streamed into the mv might not be checkpointed yet. So it will not be visible, leading to the inconsistency between upstream and downstream mv.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.