Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate backfill tests to deterministic integration tests #13219

Merged
merged 23 commits into from
Nov 6, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 2, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Part of #12957

  1. Refactor the background ddl tests. Moved them to deterministic tests, to make the tests more stable and maintainable.
  2. Improve trace level logging of no_shuffle_backfill to debug some bug.
  3. Fix error log of FlowControlExecutor, previously it used to wrong number to indicate cardinality.
  4. Fix bug where recovered stream job did not require checkpoint barrier to complete. Without checkpoint barrier, once the stream job becomes exposed to frontend, the batch query will read from the latest checkpoint barrier.
    Now upstream data could have been checkpointed several epoch's ago, so it will return the full data.
    But the latest snapshot data being streamed into the mv might not be checkpointed yet. So it will not be visible, leading to the inconsistency between upstream and downstream mv.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel force-pushed the kwannoel/fix-backfill-tests branch from 1e4de06 to a225173 Compare November 2, 2023 10:04
@kwannoel kwannoel changed the title chore: migrate backfill tests to deterministic integration tests refactor: migrate backfill tests to deterministic integration tests Nov 2, 2023
@kwannoel kwannoel marked this pull request as draft November 3, 2023 07:39
@kwannoel
Copy link
Contributor Author

kwannoel commented Nov 3, 2023

Now just fixing the main-cron test. Seems like workload is too heavy

@kwannoel kwannoel marked this pull request as ready for review November 3, 2023 14:10
@kwannoel kwannoel force-pushed the kwannoel/fix-backfill-tests branch from 02b0d23 to e168f22 Compare November 3, 2023 14:11
@kwannoel
Copy link
Contributor Author

kwannoel commented Nov 3, 2023

PTAL again @chenzl25 @BugenZhao

@chenzl25
Copy link
Contributor

chenzl25 commented Nov 3, 2023

The PR description needs to be changed as well.

@chenzl25
Copy link
Contributor

chenzl25 commented Nov 3, 2023

A related issue #9178

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #13219 (ba023ea) into main (8b58861) will decrease coverage by 0.08%.
Report is 16 commits behind head on main.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##             main   #13219      +/-   ##
==========================================
- Coverage   68.13%   68.06%   -0.08%     
==========================================
  Files        1515     1515              
  Lines      257111   257114       +3     
==========================================
- Hits       175191   175011     -180     
- Misses      81920    82103     +183     
Flag Coverage Δ
rust 68.06% <63.63%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/barrier/progress.rs 21.95% <100.00%> (+0.27%) ⬆️
src/meta/src/barrier/mod.rs 82.27% <91.66%> (+0.09%) ⬆️
...tream/src/executor/backfill/no_shuffle_backfill.rs 0.00% <0.00%> (ø)
src/stream/src/executor/flow_control.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/ddl_controller.rs 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kwannoel kwannoel force-pushed the kwannoel/fix-backfill-tests branch from a45edbf to 3d17200 Compare November 3, 2023 15:32
@kwannoel kwannoel force-pushed the kwannoel/fix-backfill-tests branch from 3d17200 to ba023ea Compare November 3, 2023 16:21
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwannoel kwannoel added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit ad92d46 Nov 6, 2023
6 of 7 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-backfill-tests branch November 6, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants