feat: report stream error for create streaming jobs #13108
Conversation
|
May I ask is this related to #12996 (comment)? |
Yes, it is. And I tried to maintain a mechanism in local barrier manager to distinguish the root cause error, but failed. 🥵 Any ideas? |
|
Do we have some test scenarios for it?
Can we:
Is that sufficient? It may not cover all propagated errors, but I think it's most common. |
Yes, that's exactly what I tried. see #12996 (comment) |
|
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | ee60ab8 | ci/scripts/regress-test.sh | View secret |
| 9425213 | Triggered | Generic Password | ee60ab8 | ci/scripts/e2e-source-test.sh | View secret |
| 9425213 | Triggered | Generic Password | ee60ab8 | ci/scripts/e2e-source-test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| if let Some(t) = tables.get(&table.id) | ||
| && let Ok(StreamJobStatus::Creating) = t.get_stream_job_status() | ||
| { | ||
| fn check_table_creating(tables: &BTreeMap<TableId, Table>, table: &Table) -> MetaResult<()> { |
There was a problem hiding this comment.
Cc @kwannoel , Before the table in Foreground is marked as created, if recovery occurs, it will be cleaned up by clean_dirty_tables. Changed this function to check and return an error if it's cleaned.
The corner case was found in this run: https://buildkite.com/risingwavelabs/pull-request/builds/43296#018df426-a3da-48cc-af24-f09eb061a320
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #11374 , related #15179 .
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.