-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: report user errors and abort mv creation directly during backfilling? #13035
Comments
We have background ddl right now, for background ddl it seems we can't report user errors easily. Furthermore, we will have sink into table later. It also relies on backfilling, but it looks like it should not abort because it will cause a partial update. However, this idea is good for debugging, maybe we can apply it the the frontend mv creation and provide a system variable to let users decide which mode to use. |
+1 for system / session variable support |
This comment was marked as resolved.
This comment was marked as resolved.
It seems this provided the reporting mechanism. The main problem for this is that "parsing and expression errors" are ignored/tolerated, so they are not considered "errors", and will also not be propagated. We might need to add a mechanism to change the behavior of error handling, like ignore when streaming, but report when backfilling. One challenge may be that the code for tolerating errors are scattered in many places. |
This comment was marked as resolved.
This comment was marked as resolved.
Is source error also the case? Somehow similar to #15587 (comment). |
This comment was marked as resolved.
This comment was marked as resolved.
Per offline discussion: reporting error on backfilling is still useful.
I think not started yet. There are a few design problems to investigate. |
Currently, we'll ignore and just warn all parsing and expression errors of streaming jobs (mview). It may be friendly for online jobs, but confusing for the mview creator.
It'll be better if the mview creation will be aborted when meeting errors during backfilling.
The text was updated successfully, but these errors were encountered: