Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use dockerhub's image by default #13067

Merged
merged 8 commits into from
Oct 31, 2023
Merged

chore: use dockerhub's image by default #13067

merged 8 commits into from
Oct 31, 2023

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Oct 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

ghcr's access may be slow in some countries. Dockerhub is generally more user-friendly.
On the other hand, I also remove connector node from integration tests, given that we have embedded it in the compute node.

Checklist

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13067 (8579604) into main (4fde65f) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13067      +/-   ##
==========================================
+ Coverage   68.26%   68.28%   +0.01%     
==========================================
  Files        1501     1501              
  Lines      252841   252841              
==========================================
+ Hits       172602   172650      +48     
+ Misses      80239    80191      -48     
Flag Coverage Δ
rust 68.28% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@neverchanje neverchanje marked this pull request as draft October 26, 2023 08:13
@neverchanje neverchanje marked this pull request as ready for review October 26, 2023 08:28
@neverchanje neverchanje requested a review from lmatz October 26, 2023 08:28
@neverchanje neverchanje enabled auto-merge October 26, 2023 08:42
@gitguardian
Copy link

gitguardian bot commented Oct 31, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7648795 Generic CLI Secret 523c140 integration_tests/iceberg-cdc/run_test.sh View secret
7648795 Generic CLI Secret 523c140 integration_tests/iceberg-cdc/docker-compose.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neverchanje neverchanje requested a review from a team as a code owner October 31, 2023 02:35
@neverchanje neverchanje added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit 9e334d7 Oct 31, 2023
7 checks passed
@neverchanje neverchanje deleted the wt-doc-issue branch October 31, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants