Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove connector-node from docker #13344

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Nov 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Remove connector-node from docker-compose file.

Actually, #13067 has already removed it (here)... cc. @neverchanje

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #13344 (d7c57cb) into main (b8b812d) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d7c57cb differs from pull request most recent head adf17b8. Consider uploading reports for the commit adf17b8 to get more accurate results

@@            Coverage Diff             @@
##             main   #13344      +/-   ##
==========================================
- Coverage   67.74%   67.74%   -0.01%     
==========================================
  Files        1524     1524              
  Lines      259436   259425      -11     
==========================================
- Hits       175766   175751      -15     
- Misses      83670    83674       +4     
Flag Coverage Δ
rust 67.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Base automatically changed from eric/12537_docker_compose_add_resource_limit to main November 10, 2023 02:27
@fuyufjh fuyufjh enabled auto-merge November 10, 2023 03:42
@fuyufjh fuyufjh added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit 1abe9e8 Nov 10, 2023
5 of 6 checks passed
@fuyufjh fuyufjh deleted the eric/remove_connector_node branch November 10, 2023 03:46
@neverchanje
Copy link
Contributor

Thanks. I forgot to remove the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants