Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(standalone): hide etcd password in logs #13034

Merged
merged 3 commits into from
Oct 26, 2023

Merge branch 'main' into kwannoel/print-failed-mv

828d22a
Select commit
Loading
Failed to load commit list.
Merged

fix(standalone): hide etcd password in logs #13034

Merge branch 'main' into kwannoel/print-failed-mv
828d22a
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Oct 26, 2023 in 1s

1 secret uncovered!

1 secret were uncovered from the scan of 3 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #13034: kwannoel/print-failed-mv 👉 main
GitGuardian id Secret Commit Filename
7648795 Generic CLI Secret 828d22a integration_tests/iceberg-cdc/run_test.sh View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!