fix(standalone): hide etcd password in logs #13034
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13034 +/- ##
==========================================
- Coverage 68.23% 68.23% -0.01%
==========================================
Files 1499 1499
Lines 252493 252496 +3
==========================================
- Hits 172301 172295 -6
- Misses 80192 80201 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| true => Some((opts.etcd_username, opts.etcd_password)), | ||
| true => Some(( | ||
| opts.etcd_username, | ||
| opts.etcd_password.expose_secret().to_string(), |
There was a problem hiding this comment.
Hmmm, I feel ideally we should make all the intermediate stuff Secret, and reveal secret until we have to. Just checked MetaStoreBackend also #[derive(Debug)]. 🤣
Just raise this point. Not a hard requirement for now.
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7648795 | Generic CLI Secret | 828d22a | integration_tests/iceberg-cdc/run_test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
BugenZhao
changed the title
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fixes #13005.
A quick hack to hide the pwd, without having to introduce a full custom display trait.Hides the etcd password by wrapping the field in
redact::Secret.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.