refactor(source): remove upsert_avro_primary_key and separate extracting columns and bind pk
#13023
Conversation
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 7648795 | Generic CLI Secret | b6ec38e | integration_tests/iceberg-cdc/run_test.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov Report
@@ Coverage Diff @@
## main #13023 +/- ##
==========================================
- Coverage 68.31% 68.27% -0.05%
==========================================
Files 1498 1498
Lines 252688 252666 -22
==========================================
- Hits 172636 172496 -140
- Misses 80052 80170 +118
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| info: &StreamSourceInfo, | ||
| with_properties: &HashMap<String, String>, | ||
| ) -> Result<(Vec<ColumnCatalog>, Vec<String>)> { | ||
| ) -> Result<Option<Vec<String>>> { |
There was a problem hiding this comment.
give an empty vec instead?
There was a problem hiding this comment.
Sure I can do this, but it might need further refactoring that is still in discussion.
| || non_generated_sql_defined_columns[0].name.real_value() != columns[0].name() | ||
| || non_generated_sql_defined_columns[1].name.real_value() != columns[1].name() |
There was a problem hiding this comment.
it can be dangerous indexing by number
There was a problem hiding this comment.
There was a problem hiding this comment.
You should apply the De Morgan's laws here. 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
upsert_avro_primary_key, which is never used.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.